feat(monitor): introduce MonitorStatus #780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FalcoSuessgott
force-pushed
the
monitor
branch
3 times, most recently
from
1dbbc48
to
d9034a1
Compare
|
Tested it on my end with // New returns a new scheduler.
func New(monitor gocron.MonitorStatus) Scheduler {
s, err := gocron.NewScheduler(
gocron.WithMonitorStatus(monitor),
gocron.WithLogger(slog.Default()),
gocron.WithGlobalJobOptions(
gocron.WithSingletonMode(gocron.LimitModeReschedule),
),
)
if err != nil {
log.Fatalf("could not start scheduler: %v", err)
}
return Scheduler{s}
}
func (c *Collector) RecordJobTimingWithStatus(startTime, endTime time.Time, uid uuid.UUID, name string, _ []string, status gocron.JobStatus, err error) {
log.Printf("[%s (%s)] %s - %s => %v\n", name, uid, startTime, endTime, status)
}
func (c *Collector) RecordJobTiming(startTime, endTime time.Time, _ uuid.UUID, name string, _ []string) {}
func (c *Collector) IncrementJob(id uuid.UUID, name string, tags []string, status gocron.JobStatus) {}And the output is exactly what I need: ....
2024/09/20 09:45:14 [vmware_vm (23dbda12-79ec-4f5d-989a-c240dd636639)] 2024-09-20 09:45:14.468317 +1000 AEST m=+13.162815626 - 2024-09-20 09:45:14.769485 +1000 AEST m=+13.463985126 => success
.... |
FalcoSuessgott
force-pushed
the
monitor
branch
from
d9034a1
to
c4c4bc0
Compare
FalcoSuessgott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
In regard of #775, This PR introduces a new interface
MonitorStatusthat encapsulatesMonitorbut addsRecordJobTimingStatus(startTime, endTime time.Time, id uuid.UUID, name string, tags []string, status JobStatus, err error), to allow recording a Job with its name, tags, start & end time, as well as the job status and error. I choose to add a new interface instead of changingMonitorto prevent introducing a breaking change.Which issue(s) does this PR fix/relate to?
Fixes #775
List any changes that modify/break current functionality
none
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.go(ExampleWithMonitor()is commented out :D)README.mdNotes
I believe having the
JobStatusanderrorinRecordJobTiming, definitely make sense, in case you're fine with it we can also just extendMonitoreven if it means having a breaking change ...